Open dejangrubisic opened 1 year ago
Oh cool! Okay, I think adding it as a submodule makes sense. Only thing I'd like to check is that this won't break the make -C examples test
invocation as pytest may pick up the sources in your repo and try running them.
I see the CI is broken (not by you). I'll test locally before giving the green light to merge.
Cheers, Chris
Merging #777 (683d44a) into development (768e4b7) will decrease coverage by
8.39%
. The diff coverage isn/a
.
Hi @dejangrubisic!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
I've filed #778 for the CI signals. Once I've fixed that I'll ping you to rebase this PR on development
.
Other than that, I checked out the loop_tune repo locally and all looks good. One thing you may want to consider is pinning your CompilerGym dependency in requirements.txt
, though that isn't merge blocking.
Cheers, Chris
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Adding LoopTune under the example directory.