search

facebookresearch / DCPerf

DCPerf benchmark suite for hyperscale cloud applications
MIT License
136 stars 11 forks source link

Increase latency by 6% #25

Closed criscasillas closed 1 year ago

criscasillas commented 2 years ago

Signed-off-by: Casillas Ahumada, Cristian M cristian.m.casillas.ahumada@intel.com

criscasillas commented 2 years ago

This change fixes cross platform performance issues.

facebook-github-bot commented 1 year ago

@excelle08 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

excelle08 commented 1 year ago

Hi @criscasillas, can you elaborate a little bit more about the reason for increasing feedsim latency criteria by 6%?

criscasillas commented 1 year ago

Hi, when we run on ICX or SPR sometimes we hit a single high latency on new qps loop (f.e 501 msec) and due to that QPS picked is lower than QPS reached on that loop. To prevent that, we increase 6% only on new qps loop since we reduce latency later and that fixes QPS selection when just a single iteration had high latency.