search

facebookresearch / DCPerf

DCPerf benchmark suite for hyperscale cloud applications
MIT License
116 stars 5 forks source link

Wrong name for the importlib resources #4

Closed ss7pro closed 2 years ago

ss7pro commented 2 years ago

This should be: import importlib_resources

https://github.com/facebookresearch/DCPerf/blob/9146203daeb8f78572bedc6e8287588e8d0bc750/benchpress/config/__init__.py#L24 https://github.com/facebookresearch/DCPerf/blob/9146203daeb8f78572bedc6e8287588e8d0bc750/benchpress/config/__init__.py#L32 https://github.com/facebookresearch/DCPerf/blob/9146203daeb8f78572bedc6e8287588e8d0bc750/benchpress/config/__init__.py#L35 https://github.com/facebookresearch/DCPerf/blob/9146203daeb8f78572bedc6e8287588e8d0bc750/benchpress/config/__init__.py#L38

Our Python is 3.8.12

Found by Phil

excelle08 commented 2 years ago

Hi Tomasz,

Does the python3 in your system point to 3.8.12 or an older version? If it still points to the older version (like 3.6) then you can use alternatives --config python3 to make python3 point to the newer one. Besides, you may need to use pip-3.8 instead of pip3 to have the required python packages installed in python 3.8's library.

importlib_resources is a third-party PyPI package that provides backport for python older than 3.7. For Python of later than 3.7, it should be importlib.resources (https://docs.python.org/3/library/importlib.html#module-importlib.resources)

ss7pro commented 2 years ago

thanks!