search

facebookresearch / DCPerf

DCPerf benchmark suite for hyperscale cloud applications
MIT License
137 stars 11 forks source link

We should provide a way to provide interface name as an parameter to benchpress #5

Closed ss7pro closed 2 years ago

ss7pro commented 2 years ago

https://github.com/facebookresearch/DCPerf/blob/9146203daeb8f78572bedc6e8287588e8d0bc750/packages/tao_bench/run.py#L52

adhanotia commented 2 years ago

@ss7pro - Trying to understand the rationale here. Do you intend to use something other than ethtool to apply these settings?

ss7pro commented 2 years ago

No, ethtool is good. It's just hardcoded interface name eth0 which should be parameterized.

adhanotia commented 2 years ago

"--interface-name" is now available as an input option in TaoBench.

./benchpress_cli.py run tao_bench_64g -r server -i '{"interface_name": }'