facebookresearch / DeepHandMesh

Official PyTorch implementation of "DeepHandMesh: A Weakly-Supervised Deep Encoder-Decoder Framework for High-Fidelity Hand Mesh Modeling," ECCV 2020
Other
94 stars 13 forks source link

parameter naming in DiffableRenderer.py #6

Open wetoo-cando opened 2 years ago

wetoo-cando commented 2 years ago

There is an ambiguity in the parameter naming for this function:

forward(self, mesh, cam_param, img_affine_trans_mat, mesh)

The parameter name mesh gets repeated twice. Can you please check?

https://github.com/facebookresearch/DeepHandMesh/blob/ea90b752bf758076c64331cb38db497a181f8a06/common/nets/DiffableRenderer/DiffableRenderer.py#L27

mks0601 commented 2 years ago

Sorry I've updated the file!