search

facebookresearch / DensePose

A real-time approach for mapping all human pixels of 2D RGB images to a 3D surface-based model of the body
http://densepose.org
Other
6.98k stars 1.3k forks source link

No .md5 files #172

Closed Viliami closed 5 years ago

Viliami commented 5 years ago

Detectron (main repo, not the included subfolder) does a md5 hash verification before it downloads weights in this line: 

    """By convention the md5 hash for url is stored in url + '.md5sum'."""
    url_md5sum = url + '.md5sum'
    md5sum = urllib.request.urlopen(url_md5sum).read().strip()
    return md5sum

However it appears there are no md5 hashes on the S3 server https://s3.amazonaws.com/densepose/DensePose_ResNet101_FPN_s1x-e2e.pkl (valid link) https://s3.amazonaws.com/densepose/DensePose_ResNet101_FPN_s1x-e2e.pkl.md5sum (invalid link)

Could you upload the md5sum hashes to the S3 server?

I can see that this was fixed by commenting out the line that verifies the hashes in the Detectron module subfolder but it would be good if this code worked with the main Detectron repo.

vkhalidov commented 5 years ago

Thanks for flagging @Viliami , links will soon be updated (similar to the main Detectron repo)

vkhalidov commented 5 years ago

@Viliami Resource links have been updated (#181 ), md5 files now have links that are coherent with Detectron logic (formed as a resource file URL concatenated with '.md5sum'). Closing the issue, but feel free to reopen it if you find any inconsistency. Thanks again for flagging the issue!