search

facebookresearch / DomainBed

DomainBed is a suite to test domain generalization algorithms
MIT License
1.42k stars 298 forks source link

New hparam registry #25

Closed igul222 closed 4 years ago

igul222 commented 4 years ago

This should fix #16 . @lopezpaz can you do a code-review? In particular, I can't think of any edge-cases / interactions with sweep etc. that this breaks, but this has historically been a tricky part of the codebase.

lopezpaz commented 4 years ago

Should we add algorithm to the arguments of seed_hash here? Otherwise if two algorithms have a parameter with the same name, their random values would be tied, even if they correspond to different things or have different scales. The rest looks good to me!