facebookresearch / DrQA

Reading Wikipedia to Answer Open-Domain Questions
Other
4.48k stars 898 forks source link

Any plans for supporting 3.7+ #246

Closed ebal5 closed 4 years ago

ebal5 commented 4 years ago

according to #227 or #35 , there is no support for Python 3.7+ I think. Today (2020-04-17), I tried to use DrQA with 3.8, I found this problem.

Does this project has any plans for support Python 3.7+? In other words, is there any plans for updating dependency of pexpect?

hughperkins commented 4 years ago

You can use --tokenizer regexp, to workaround the pexpect issue. (just install the latest version of pexpect, since it wont be used if you dont use stanford core nlp tokenizer)

hughperkins commented 4 years ago

(otherwise, you'd need to upgrade corenlp_tokenizer.py to the latest stanfordcorenlp recommended usage pattern)

ebal5 commented 4 years ago

Thanks a lot.