mnist_vae: update README and fix hidden size in the sender

facebookresearch / EGG

EGG: Emergence of lanGuage in Games

MIT License

286 stars 99 forks source link

mnist_vae: update README and fix hidden size in the sender #109

Closed Slowika closed 3 years ago

Slowika commented 4 years ago

I'm adding small fixes to the mnist_vae game.

facebook-github-bot commented 4 years ago

Hi @Slowika!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

eugene-kharitonov commented 4 years ago

Hello @Slowika, thanks for the fix!

Once you either sign CLA or update your internal FB profile with your github account, I'll be able to merge this PR.

Slowika commented 4 years ago

Hi, thanks a lot @eugene-kharitonov ! I think I might have hurried up with the pull request and the dimensions are ok! I would only fix the README and I can add changes to make it work with other datasets apart from MNIST. I have updated the internal FB profile with my github account.

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!