search

facebookresearch / EGG

EGG: Emergence of lanGuage in Games
MIT License
286 stars 99 forks source link

beta-VAE on dSprites #116

Closed Slowika closed 3 years ago

Slowika commented 3 years ago

Implementation of beta-VAE as a communication game (based on mnist_vae). The game includes a data loader for dSprites, a procedurally generated dataset for studying disentanglement properties.

robertodessi commented 3 years ago

Hi @Slowika, thanks a lot for the implementation of the game! I did not know about the paper so it'll be a great chance to check it out and it seems a great add to EGG :)

As suggested and started by @eugene-kharitonov, we tried to add simple dummy tests that check if egg-games fail https://github.com/facebookresearch/EGG/blob/master/tests/test_games_do_not_fail.py It's useful if big changes to egg/core are introduced. I think it'd be nice to have it for the beta-VAE game as well

eugene-kharitonov commented 3 years ago

Cool, thanks @Slowika ! Just some minor comments

Slowika commented 3 years ago

Thanks for the comments @robertodessi and @eugene-kharitonov :) I cleaned it up a bit and added a test. Let me know if you have other suggestions!