Improving checks for shapes in Reinforce

facebookresearch / EGG

EGG: Emergence of lanGuage in Games

MIT License

286 stars 99 forks source link

Closed eugene-kharitonov closed 3 years ago

eugene-kharitonov commented 3 years ago

The existing check (_verify_batch_size) is a bit too strict:

It is OK for Receiver to return zero-scalar constant as log-probs
It is OK to use wrongly-shaped losses as long as they are only used in evaluation

On top of that, a couple fixes for places where the check was triggered.

eugene-kharitonov commented 3 years ago

Thanks @robertodessi !