facebookresearch / EGG

EGG: Emergence of lanGuage in Games
MIT License
286 stars 99 forks source link

Lengths are not passed to the RNN Encoder #128

Closed eugene-kharitonov closed 3 years ago

eugene-kharitonov commented 3 years ago

Passing an-already computed lengths of a message is a micro-optimization.

Apparently, it is lost in here: https://github.com/facebookresearch/EGG/blob/63a9e0dae9cb72e63d9191c633d346747e45ce5b/egg/core/reinforce_wrappers.py#L300

Thanks @robertodessi for spotting!