Standardize naming of test/validation set in callbacks vs trainer

facebookresearch / EGG

EGG: Emergence of lanGuage in Games

MIT License

286 stars 99 forks source link

Standardize naming of test/validation set in callbacks vs trainer #156

Closed mbaroni closed 3 years ago

mbaroni commented 3 years ago

In the trainer file a validation loop refers to validation data etc, in the callbacks we have a method called on_test_end. Maybe it should be named on_validation_end?