facebookresearch / EGG

EGG: Emergence of lanGuage in Games
MIT License
281 stars 99 forks source link

Merge posdis and bosdis #170

Closed robertodessi closed 3 years ago

robertodessi commented 3 years ago

Is your proposal related to a problem?

Merging posdis and bos might be useful to reduce the number of callbacks to pass to the trainer (h/t @eugene-kharitonov)

Describe the solution you'd like to have implemented

Have a singel Disent callback (optionally) computing both metrics

Additional context

It has a very low priority. Good as a first issue for someone that wants to understand the logic behind the callbacks

robertodessi commented 3 years ago

Fixed in #211