search

facebookresearch / EGG

EGG: Emergence of lanGuage in Games
MIT License
281 stars 99 forks source link

Abstract Logging Strategy class #172

Closed nicofirst1 closed 3 years ago

nicofirst1 commented 3 years ago

Abstracted LoggingStrategy class to allow for subclassing. Solves this issue

facebook-github-bot commented 3 years ago

Hi @nicofirst1!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

eugene-kharitonov commented 3 years ago

Thanks a lot! I have few comments above.

robertodessi commented 3 years ago

This looks slightly convoluted though. How about something like this? https://github.com/facebookresearch/EGG/compare/master...robertodessi:tmp

eugene-kharitonov commented 3 years ago

@robertodessi also nice, but what if we init prob to 1.0 and use this as the only interaction impl? :)

robertodessi commented 3 years ago

mmh, sounds a bit odd to have the prob parameter and (I'm assuming) most of the times will be used as set to 1 but I don't have any strong counterarguments for having a subclass so I guess you're right, let's go in that direction :D

nicofirst1 commented 3 years ago

To me @robertodessi 's solution looks cleaner

robertodessi commented 3 years ago

I'll go ahead and close this then