Adding kwargs for SenderReceiverRnnReinforce

facebookresearch / EGG

EGG: Emergence of lanGuage in Games

MIT License

281 stars 99 forks source link

Adding kwargs for SenderReceiverRnnReinforce #174

Closed nicofirst1 closed 3 years ago

nicofirst1 commented 3 years ago

Implements feature requested here

robertodessi commented 3 years ago

In general I think this is an ok solution but we can discuss whether it could make sense to wait and think about another approach that maybe involves this https://github.com/facebookresearch/EGG/issues/159 ?

eugene-kharitonov commented 3 years ago

Yeah, agree with @robertodessi here: I actually think we should look into ways to encapsulate data, rather than exploding it further.

nicofirst1 commented 3 years ago

I'm willing to work on #159 since I need that additional input. But could you please elaborate what do you need from it? The databatch is passed at training time from the dataLoader to the game, so should it be returned by the dataloader? Once passed how can it be stored in the Iteration list for further processing?