search

facebookresearch / EGG

EGG: Emergence of lanGuage in Games
MIT License
281 stars 99 forks source link

Add progress bar as a callback #176

Closed nicofirst1 closed 3 years ago

nicofirst1 commented 3 years ago

Regarding this issue

nicofirst1 commented 3 years ago

The tests fail because some error in how the len is defined in simple_autoenc, channel and lanaguae bottleneck.

I believe they all implemented the same onehot loader which does not have the _dataset_kind attribute.

Rather than catch this exception I would correct those game.

eugene-kharitonov commented 3 years ago

Oh, there is a lot here! :) Could you please unpack in different PRs those two changes? It would be faster to proceed, cause /1/ is trivial and /2/ might deserve some discussion: /1/ Adding on_batch /2/ Adding tqdm part (preferably in a separate logger; also you'd need to add tqdm to requirements.txt?) Also 3/ There are lots of indentation changes, maybe they are valid, but it would be better not to mix changes to codestyle/formatting in random places with meaningful changes. 4/ Also there are pieces of another PR, I think? Could you please rebase this branch on top of master? Otherwise it could be messy-ish.

robertodessi commented 3 years ago

CI tests are failing since tqdm is not being imported. If it's added to the requirements file it should be fine

nicofirst1 commented 3 years ago

I see now that I was not on the master branch, I'm creating two other PRs with cleaner version (@eugene-kharitonov ). I'm not closing this yet so we can still use @robertodessi 's work