search

facebookresearch / EGG

EGG: Emergence of lanGuage in Games
MIT License
291 stars 103 forks source link

Progress Bar for epochs #184

Closed nicofirst1 closed 3 years ago

nicofirst1 commented 3 years ago

Adding progress bar for epochs both in training and testing.

robertodessi commented 3 years ago

Thanks, except minor comments it looks nice!

Nit: Do you know if rich is faster than tqdm or did you do any test? I mean rich-callback vs tqdm-callback or plain tqdm.

nicofirst1 commented 3 years ago

For a comparison between tqdm and rich you can refer to this issue

robertodessi commented 3 years ago

yep I read those already but it mentions comparable performance for quick iterations, it'd be nice to check for long runs like your coco use case but I think it is not so important now, we can leave it as is

nicofirst1 commented 3 years ago

Is everything ok with this PR? I have some updates but would like to create a new PR based on this one

robertodessi commented 3 years ago

Except these (very) minor comments it looks good to me! If @eugene-kharitonov agrees we could merge Meanwhile you could branch out of your own branch and commit the updates there