search

facebookresearch / EGG

EGG: Emergence of lanGuage in Games
MIT License
287 stars 100 forks source link

Bug in dump interaction #240

Closed robertodessi closed 1 year ago

robertodessi commented 2 years ago

The function to dump interaction does not return all of them but just last one due to a typo in a variable name https://github.com/facebookresearch/EGG/blob/main/egg/core/interaction.py#L283

This function should be somehow merged with the static method in this callback https://github.com/facebookresearch/EGG/blob/main/egg/core/callbacks.py#L295-L305

(h/t @davidelct)

robertodessi commented 1 year ago

Fixed in #241