facebookresearch / EGG

EGG: Emergence of lanGuage in Games
MIT License
281 stars 99 forks source link

Adding experiments to zoo #245

Closed michal-au closed 2 years ago

michal-au commented 2 years ago

Description

This code implements the experiments reported in the following paper:

It is a response to/extension of the experiments implemented in zoo/compo_vs_generalization

How Has This Been Tested?

A typical testing for a research code: no tests at all... Though, I re-run all the experiments just before creating the PR to see if something was off (and it was not!)

robertodessi commented 2 years ago

HI @michal-au,

Thanks a lot for contributing to EGG with your paper. We currently try to enforce the usage of black as code formatting style (along with pysort, flake8 and the copyright header).

It seems 4 files are currently failing the black-style check, namely,

As soon as you can fix these I'm happy to merge the PR :)

robertodessi commented 2 years ago

Hey @michal-au, thanks for fixing the formatting issue. it seems the only thing left now it the copyright header. All files, including __init__.py files, should contain a specific header, you can find it in any file in EGG.

Additionally, I seem to understand that you game mostly expand the compo_generalization one and uses symbolic input. We try to add a basic test to check that future commits won't break game logics. You can find an example here. Could you maybe add a test with some dummy but quick and meaningful input?

Thanks!

robertodessi commented 2 years ago

It seems the two init file do not pass the black check. Could it be a newline at the end of file?

michal-au commented 2 years ago

:partying_face: Thanks @robertodessi for helping out. I found a list of experiments in the main readme so I also updated that if that's fine.

robertodessi commented 2 years ago

Sure! Thanks a lot for contributing to EGG! :)