search

facebookresearch / EGG

EGG: Emergence of lanGuage in Games
MIT License
286 stars 99 forks source link

Colab not working #94

Closed JazminVidal closed 4 years ago

JazminVidal commented 4 years ago

Hi all!

I've been trying to play with the MNIST example in Google Colab but it seems EGG assumes Python 3.7 or higher and Google Colab is still 3.6 :(

I'll try with an older version of the repo.

Thanks

eugene-kharitonov commented 4 years ago

Ah, indeed, I've used a few dataclasses recently which were introduced in python3.7 =| Let me see if I can replace them with something.

Thanks for flagging!

eugene-kharitonov commented 4 years ago

As a temporary solution: perhaps you can go a bit back in history (eg checkout EGG v1.0 tag?), where I didn't break it for python3.6 yet...

eugene-kharitonov commented 4 years ago

Nvm, I have a small fix, will put it in later in the day. Thanks!

eugene-kharitonov commented 4 years ago

Should be working now, thanks @JazminVidal for raising the issue!

eugene-kharitonov commented 4 years ago

I think it worked for me now, please re-ping if it is not the case. Thanks again!

JazminVidal commented 4 years ago

Yes! It works :D So happy to use it.

Just a really stupid detail, I think you repeat the lines

sender = Sender(vision, output_size=400) receiver = Receiver(input_size=400)

when you define sender and receiver classes and in the training with Gumble-Softmax cell. The first time with output_size=400 and the second time with output_size=10.

But, again, I'm extremely new to this and a linguist, hahah.

Thanks for your answers,

J

El vie., 7 ago. 2020 a las 6:28, eugene-kharitonov (< notifications@github.com>) escribió:

I think it worked for me now, please re-ping if it is not the case. Thanks again!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/facebookresearch/EGG/issues/94#issuecomment-670425210, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJBTCWCYZQHCAICXAH3XUQTR7PCKVANCNFSM4PV7TKKA .

-- Jazmín

eugene-kharitonov commented 4 years ago

Argh, probably. Thanks! will fix a bit later =D