facebookresearch / ELF

An End-To-End, Lightweight and Flexible Platform for Game Research
Other
2.09k stars 285 forks source link

Trouble fixing Travis CI build #136

Open douglasrizzo opened 4 years ago

douglasrizzo commented 4 years ago

I was trying to fix the CI build. I noticed that an error occurs in the .travis.yml file in the following lines:

- (mkdir rts/build_MC && cd rts/build_MC && cmake .. -DGAME_DIR=../game_MC && make)
- (mkdir rts/build_CF && cd rts/build_CF && cmake .. -DGAME_DIR=../game_CF && make)
- (mkdir rts/build_TD && cd rts/build_TD && cmake .. -DGAME_DIR=../game_TD && make)

The first line had a problem related to using the wrong Python executable, so I fixed it by pointing it towards what looks like the right executable inside the Travis container using -DPYTHON_EXECUTABLE=/opt/pyenv/shims/python.

The following two lines, however, are attempting to compile the contents of the build_CF and build_TD directories, which appear to have incomplete files. Can anyone tell me what these directories contain?

douglasrizzo commented 4 years ago

Okay, CF is Capture the Flag and TD is Tower Defense, but they don't seem to compile, as there are references to object types missing inside some files...

douglasrizzo commented 4 years ago

The last commit that had a successful build was b02f407ca0f06656e3201728a44b5e3df1afb9c7.

Commit 8d2f76955bf655a2885dc3ed0c30a8c4e1b6b8b3 (Oct 2018) made changes to the elf base libraries and to the MC project. The changes to the base libraries broke compilation of TD and CF, whose latest commit date back to Apr 2018.

I see a few possible solutions to the problem.

Any suggestions or insights?