search

facebookresearch / FAMBench

Benchmarks to capture important workloads.
Apache License 2.0
28 stars 23 forks source link

Pointing to pinned mmcv version #123

Closed zstreet87 closed 11 months ago

zstreet87 commented 12 months ago

MMCV has had major refactors splitting into MMEngine etc. As BEVT isn't maintained anymore, recommendation is to pull from another mmcv that has rocm specific patches on top but has the same old API BEVT is expecting.

One thing to note, this dockerfile should be tested. Building apex is not needed if using rocm/pytorch;latest as base image at the time of creating this PR.

zstreet87 commented 11 months ago

@samiwilf

samiwilf commented 11 months ago

@zstreet87 I left Meta. @erichan1 should be able to approve

zstreet87 commented 11 months ago

@erichan1 can you take a look please?

zstreet87 commented 11 months ago

@amathews-amd please add yourself as a reviewer

zstreet87 commented 11 months ago

Just created a new branch by first checking out the last commit before the major migration (see here: https://github.com/open-mmlab/mmcv/releases/tag/v1.7.0) and then added the rocm patch needed on top.

I'm not sure why there are so many "commits ahead" but perhaps the major migration did a rebase or something.

amathews-amd commented 11 months ago

Just created a new branch by first checking out the last commit before the major migration (see here: https://github.com/open-mmlab/mmcv/releases/tag/v1.7.0) and then added the rocm patch needed on top.

I'm not sure why there are so many "commits ahead" but perhaps the major migration did a rebase or something.

this looks cleaner: https://github.com/open-mmlab/mmcv/compare/v1.7.0...zstreet87:mmcv:rocm-pinn