search

facebookresearch / FAMBench

Benchmarks to capture important workloads.
Apache License 2.0
28 stars 23 forks source link

remove batch info from run_stop and add extra_metadata func #35

Closed erichan1 closed 2 years ago

erichan1 commented 2 years ago

Change interface as given in title so logger.run_stop doesn't require unnecessary arguments (eg num batches, batch size, extra_metadata). Migrate all existing uses of the logger to the new interface.

Testing: Ran run_all.sh on gpu and verified that numbers do not change significantly.

Docs to be updated to answer following question: for each score metric, what data is needed to be logged?

aaronenyeshi commented 2 years ago

Main was squashed for Open-Sourcing, please re-open against new main.