Open chongxiaoc opened 2 years ago
Thanks for the fix. Do you mind sending a pull request with the change?
@bilgeacun I would like to. But will this cause failure of building on Torch 1.6? I assume you guys have tested torch 1.6 with existing code.
We can bump the supported version to 1.7. Do you see any other problems with 1.7?
I run the benchmark on torch 1.7 and CUDA 11.2. It works so far. Let me create a PR then.
Let me test DLRM to make sure that works as well.
Actually I realized move of CUDAGeneratorImpl.h to ATen/cuda happened recently to support PT 1.11. So your change would be reverting that. See: https://github.com/pytorch/pytorch/pull/70650
Can you try PT 1.11?
I see. But our production system doesn't support PT 1.11 by now. I can close that PR then. Thanks for clarification.
It looks like torch 1.7 moves the location of header file
ATen/cuda/CUDAGeneratorImpl.h
Error:If I changed the location as below:
Installation completes.