search

facebookresearch / GENRE

Autoregressive Entity Retrieval
Other
765 stars 103 forks source link

Why do you prepend `eos_token_id' to sent_orig #92

Closed WenzhengZhang closed 2 years ago

WenzhengZhang commented 2 years ago

Hi, I'm confused about this line. Why do you prepend eos_token_id to each sent_orig instead of bos_token_id?

nicola-decao commented 2 years ago

Mmm, probably that is a bug. In all experiments eos_token_id = bos_token_id so it did not make a difference. Have you tried changing it?

WenzhengZhang commented 2 years ago

Thanks for your reply! I tried changing it and found it didn't make a difference. I found you seemed to set 2 as both eos_token_id and bos_token_id.