Closed briancoutinho closed 4 months ago
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Attention: Patch coverage is 90.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 90.83%. Comparing base (
9cad1f2
) to head (abff786
).
Files | Patch % | Lines |
---|---|---|
hta/analyzers/critical_path_analysis.py | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@briancoutinho merged this pull request in facebookresearch/HolisticTraceAnalysis@9ef98987b3dbb6efdc8ce8a40b99e663acee7edb.
What does this PR do?
Add tolerance for negative one weight due to precision issues
No need to have overlaid director exist, now just mkdir it
Before submitting
[ ] Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
[x] Did you write any new necessary tests?
[ ] Did you make sure to update the docs?
[ ] Did you update the changelog?