facebookresearch / HolisticTraceAnalysis

A library to analyze PyTorch traces.
http://hta.readthedocs.io
MIT License
270 stars 37 forks source link

[critical path] Add tolerance for negative one weight due to precision issues, improvements #138

Closed briancoutinho closed 4 months ago

briancoutinho commented 4 months ago

What does this PR do?

facebook-github-bot commented 4 months ago

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 4 months ago

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.83%. Comparing base (9cad1f2) to head (abff786).

Files Patch % Lines
hta/analyzers/critical_path_analysis.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #138 +/- ## ========================================== + Coverage 90.80% 90.83% +0.02% ========================================== Files 52 52 Lines 5186 5192 +6 ========================================== + Hits 4709 4716 +7 + Misses 477 476 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

facebook-github-bot commented 4 months ago

@briancoutinho merged this pull request in facebookresearch/HolisticTraceAnalysis@9ef98987b3dbb6efdc8ce8a40b99e663acee7edb.