Evaluate logger.debug only when needed

facebookresearch / HolisticTraceAnalysis

A library to analyze PyTorch traces.

http://hta.readthedocs.io

MIT License

293 stars 40 forks source link

Closed pavanky closed 5 months ago

pavanky commented 5 months ago

Summary: The f-strings in logger.debug get evaluated even when they are not being printed.

This change adds a redundant check to see if debug is enabled for the logger before calling logger.debug

Differential Revision: D57465366

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D57465366

facebook-github-bot commented 5 months ago

This pull request was exported from Phabricator. Differential Revision: D57465366

facebook-github-bot commented 5 months ago

This pull request has been merged in facebookresearch/HolisticTraceAnalysis@f9efe1cdf44c8ccd4de98487471ae82d623cd119.