Closed briancoutinho closed 3 months ago
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@briancoutinho merged this pull request in facebookresearch/HolisticTraceAnalysis@cc4ce6098bc73800b43a131a6d1e986b82d54230.
What does this PR do?
In constructing critical graph we tend to access elements in the dataframe individually (
.loc[]
) which is really slow. This PR will try to fix these access.add_event()
function and instead construct the nodes for all events together using the dataframe itself. This will be a lot faster.is_operator_or_runtime
call as it does indexing into the dataframe, this handled directly in node construction time.Before submitting