facebookresearch / HolisticTraceAnalysis

A library to analyze PyTorch traces.
http://hta.readthedocs.io
MIT License
293 stars 40 forks source link

[critical path] Optimize graph construction of node events #171

Closed briancoutinho closed 3 months ago

briancoutinho commented 3 months ago

What does this PR do?

In constructing critical graph we tend to access elements in the dataframe individually (.loc[]) which is really slow. This PR will try to fix these access.

Before submitting

facebook-github-bot commented 3 months ago

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@briancoutinho merged this pull request in facebookresearch/HolisticTraceAnalysis@cc4ce6098bc73800b43a131a6d1e986b82d54230.