Closed briancoutinho closed 1 month ago
Thanks for adding the support for configuring with env variables. One of my suggestion is to also support the customization through local configuration, i.e., command line option > env vars > local configuration file > default configuration file.
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@briancoutinho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
This pull request was exported from Phabricator. Differential Revision: D60842130
@briancoutinho merged this pull request in facebookresearch/HolisticTraceAnalysis@6697ab79ead19774613035b757c04358b78bf6d9.
What does this PR do?
Testing: pytest tests/test_config.py
We can also see the options.
Before submitting