facebookresearch / HolisticTraceAnalysis

A library to analyze PyTorch traces.
http://hta.readthedocs.io
MIT License
306 stars 43 forks source link

Fix test errors and type checking errors induced by a previous PR. #194

Open fengxizhou opened 1 month ago

fengxizhou commented 1 month ago

What does this PR do?

Fixes # 193 - Wrong Configuration Path Caused Test Failures

This PR fixes four things in a previous diff.

(1) A wrong file path for event_args_formats caused test errors. The fix is to update to the correct path. (2) A type checking error caused by Library stubs not installed for "yaml". The fix is to add the following lines into pyproject.toml file.

[[tool.mypy.overrides]]
module = "yaml"
ignore_missing_imports = true

(3) Update mypy setting in .pre-commit-config.yaml to workaround errors: "Source file found twice under different module names"

(4) Fix format warnings when importing sorces fbcode into github.

Before submitting

facebook-github-bot commented 1 month ago

@fengxizhou has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D64839500

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D64839500