search

facebookresearch / InferSent

InferSent sentence embeddings
Other
2.28k stars 471 forks source link

Fixing error when the vocab isn't updated #56

Closed perone closed 6 years ago

perone commented 6 years ago

This fixes an error when the vocabulary isn't updated (no new word added).

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

perone commented 6 years ago

Any chance of merging this ? It's a very simple fix.

aconneau commented 6 years ago

Hi, thanks for spotting this, I applied the fix here: 1cb7de6bb3be701cd63d52e344be8a5beb32a0c2 Best, Alexis