search

facebookresearch / InterHand2.6M

Official PyTorch implementation of "InterHand2.6M: A Dataset and Baseline for 3D Interacting Hand Pose Estimation from a Single RGB Image", ECCV 2020
Other
676 stars 92 forks source link

shouldn't the `all` folder have the validation files also ? #45

Closed MohamedAliRashad closed 3 years ago

MohamedAliRashad commented 3 years ago

It's kind of confusing to find the validation json files in machine_annot folder but not in the all folder, shouldn't it be also their or i miss-understood something ?

mks0601 commented 3 years ago

As you can see Table 2 of the paper, there is only machine_annot in validation set.

MohamedAliRashad commented 3 years ago

@mks0601 isn't the all folder contain the best results from machine_annot and human_annot ?

mks0601 commented 3 years ago

all is summation of machine_annot and human_annot. As the validation set is only consists of machine_annot (no human_annot), there is no all for the validation set.

MohamedAliRashad commented 3 years ago

@mks0601 That doesn't make any sense. machine_annot + no human_annot = machine_annot not None

mks0601 commented 3 years ago

Hey, be careful about your aggressive comment. machine_annot + no human_annot = machine_annot not None <- I cannot get what you meant by this.

The validation set only consists of machine_annot. There is no human_annot subset in the validation set. So, all of validation set would be the same with machine_annot of the validation set. Making a all json file, which is the same with machine_annot json, can make people think there is a human_annot subset in the validation set. Therefore, I did not make all json file for the validation set.

MohamedAliRashad commented 3 years ago

I am sorry, i didn't mean any offense.

it has been very bad couple of days for me, thanks for your patience and kind answers.

MohamedAliRashad commented 3 years ago

I will be closing the issue