search

facebookresearch / Kats

Kats, a kit to analyze time series data, a lightweight, easy-to-use, generalizable, and extendable framework to perform time series analysis, from understanding the key statistics and characteristics, detecting change points and anomalies, to forecasting future trends.
MIT License
4.93k stars 537 forks source link

Add typing-extensions requirement for Python 3.7 #197

Closed adamantike closed 2 years ago

adamantike commented 2 years ago

When running the project on Python 3.7, only installing requirements with:

pip install -r requirements.txt

The project fails with the following error:

$ python -c 'from kats.models.prophet import ProphetModel'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/src/kats/__init__.py", line 6, in <module>
    from . import data  # noqa # usort: skip
  File "/src/kats/data/__init__.py", line 6, in <module>
    from . import utils  # noqa
  File "/src/kats/data/utils.py", line 29, in <module>
    from typing_extensions import Literal
ModuleNotFoundError: No module named 'typing_extensions'

This is because, for Python 3.7, typing-extensions is needed as Literal is not included in stdlib's typing.

adamantike commented 2 years ago

Closing, as this has been solved in https://github.com/facebookresearch/Kats/commit/2e197e90151e5e02d3f7037b1a17a8db0d793a5b