facebookresearch / LaMCTS

The release codes of LA-MCTS with its application to Neural Architecture Search.
Other
463 stars 71 forks source link

[WIP] Add setup.py #7

Closed Yard1 closed 3 years ago

Yard1 commented 4 years ago

This PR intends to prepare the contents of LA-MCTS folder for distribution.

Only the lamcts folder will be included in the package itself.

facebook-github-bot commented 4 years ago

Hi @Yard1!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Yard1 commented 4 years ago

@linnanwang Would it be possible for you to look over the setup.py parameters (author, description, email)?

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

linnanwang commented 4 years ago

@Yard1 , thank you for your effort, this is great. I will take a look ASAP. Thank you.

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Yard1 commented 4 years ago

ATM only the lamcts folder will be included in the package itself. I think the tracker class could be moved there for convenience. One further improvement would be to create some sort of a generic wrapper around a function to optimize that would create a class which can be passed to MCTS, in order to simplify things. If you think that sounds like a good idea, I can look into it.