search

facebookresearch / NeuralCompression

A collection of tools for neural compression enthusiasts.
MIT License
496 stars 43 forks source link

fix the bug of using optical_flow_to_color in train.py #203

Closed yitai-cheng closed 1 year ago

yitai-cheng commented 1 year ago

Closes #

Changes

Change the import of optical_flow_to_color function from import _optical_flow_to_color to from neuralcompression.functional import optical_flow_to_color.

Change the function call _optical_flow_to_color.optical_flow_to_color to optical_flow_to_color

mmuckley commented 1 year ago

Hello @N1ghtstalker2022 could you run black on this PR so that it passes the tests?

yitai-cheng commented 1 year ago

OK. I'll do that.

yitai-cheng commented 1 year ago

Hello @N1ghtstalker2022 could you run black on this PR so that it passes the tests?

The black test can be passed on my machine. It should works now.

yitai-cheng commented 1 year ago

I don't know why it did not pass the test. The code can pass the test on my linux machine.

8792b5931187d1bf338e088f9f099c33
mmuckley commented 1 year ago

Hello @N1ghtstalker2022, it's just a different test, this one for isort. You can see all the tests we run here so we don't get hit with this again.

yitai-cheng commented 1 year ago

Hello @N1ghtstalker2022, it's just a different test, this one for isort. You can see all the tests we run here so we don't get hit with this again.

I've tested it again. Now it should be fine.

yitai-cheng commented 1 year ago

Shall we close this PR?

mmuckley commented 1 year ago

@N1ghtstalker2022 yes thanks so much! Sorry, was busy with some other things.