Open hamjam opened 1 year ago
Hi @hamjam!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
This PR has not had activity in 30 days. Closing due to staleness.
@jxmsML any interest in taking over this PR?
Hi Kurt, Sorry for the late reply. I was very busy lately and I forgot to check my GitHub notifications recently. I can design tests as you mentioned in 2 weeks if there is no one interested.
On Mon, Jun 5, 2023 at 10:32 PM Kurt Shuster @.***> wrote:
@jxmsML https://github.com/jxmsML any interest in taking over this PR?
— Reply to this email directly, view it on GitHub https://github.com/facebookresearch/ParlAI/pull/4978#issuecomment-1577313816, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAJPOGUBJVRJVULJZYGWM3XJYULXANCNFSM6AAAAAAVWOHFD4 . You are receiving this because you were mentioned.Message ID: @.***>
Patch description
In this PR, the train_model.py script has the option to keep and store multiple checkpoints based on validation metrics. Some checkpoints that have best validation metrics during training will be kept in the directory specified by
--model-file
. Resolves #4970Testing steps
To test this PR, you can run something like
parlai train_model --task babi:task10k:1 --model seq2seq --model-file seq2seq/babi_task10k --batchsize 32 --validation-every-n-secs 30 -stopk 5 -vstep 50
Note that-vstep
option must be exist to save and store 5 top checkpoints in this example. For me, the list of files in the-model-file
directory after 1350 steps of training is like this: