facebookresearch / ParlAI

A framework for training and evaluating AI models on a variety of openly available dialogue datasets.
https://parl.ai
MIT License
10.48k stars 2.09k forks source link

valid_world.epoch_done() in train_model.py never finishes #498

Closed jojonki closed 6 years ago

jojonki commented 6 years ago

I checked a memory networks model with babi dataset. But I found valid_world.epoch_done never finishes. https://github.com/facebookresearch/ParlAI/blob/master/examples/train_model.py#L91

jojonki commented 6 years ago

babi task is working. So this is the problem of dialog_babi.

// this is working
python examples/train_model2.py -t babi:task1k:1 -m memnn -mf /tmp/model_memnn  -e 1

In dialog_babi, episode_idx looks always 0. Then epoch_done is always False.

klshuster commented 6 years ago

The memory network operates on the validation set very slowly (it considers many more candidates than it does while training), but it is not hanging. If you give it some time, it should finish. Please reopen if you have any more questions!

jaseweston commented 6 years ago

FYI We are in the process of updating this model to make it faster

On Tue, Jan 16, 2018 at 10:31 AM, Kurt Shuster notifications@github.com wrote:

The memory network operates on the validation set very slowly (it considers many more candidates than it does while training), but it is not hanging. If you give it some time, it should finish. Please reopen if you have any more questions!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/facebookresearch/ParlAI/issues/498#issuecomment-357998812, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjk-PFQ4MqKnekx_QLHg0wvWQ6wB6SRks5tLMDmgaJpZM4RdGzX .

jojonki commented 6 years ago

@jaseweston Nice. Are there any issues related to that?

jaseweston commented 6 years ago

No.. you want me to create one?

On Mon, Jan 22, 2018 at 2:37 PM, Junki Ohmura notifications@github.com wrote:

@jaseweston https://github.com/jaseweston Nice. Are there any issues related to that?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/facebookresearch/ParlAI/issues/498#issuecomment-359540054, or mute the thread https://github.com/notifications/unsubscribe-auth/AKjk-I1FjRa2FfaploLmWPUXMi_HpdRMks5tNOORgaJpZM4RdGzX .

jojonki commented 6 years ago

It is helpful indeed. And when will you release the faster version? Please let me know if you have a plan in your mind about this.

alexholdenmiller commented 6 years ago

516