search

facebookresearch / ParlAI

A framework for training and evaluating AI models on a variety of openly available dialogue datasets.
https://parl.ai
MIT License
10.49k stars 2.1k forks source link

Sweeping the JS lint errors under the rug #5018

Closed mojtaba-komeili closed 1 year ago

mojtaba-komeili commented 1 year ago

Patch description Now that our JS lint is working, we have so many legacy JS code in our crowdsourcing. This PR fixes the ones that it can and adds lint ignore commands on those that are not trivial to resolve.

mojtaba-komeili commented 1 year ago

@klshuster sorry for the number of changes. But there is no changes to the logic of how codes work here. It is either fixing the lint issues in JS or adding skip conditions on them.