Delegated Private Matching for Compute (DPMC)

jimouris commented 1 year ago

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Docs change / refactoring / dependency upgrade

Motivation and Context / Related issue

1) Extending multi-key Private-ID to Delegated Private Matching for Compute (DPMC) which supports multiple partners with the help of a helper/delegate server.

Company has a csv with identifiers (e.g., etc/example/dpmc/Ex0_company.csv).
Partner has a csv with identifiers (e.g., etc/example/dpmc/Ex0_partner_1.csv) and a csv with features (e.g., etc/example/dpmc/Ex0_partner_1_features.csv).

2) Extending DPMC to Delegated Private Matching for Compute with Secure Shuffling (DSPMC) which supports multiple partners with the help of two helpers/delegate servers.

Company has a csv with identifiers (e.g., etc/example/dspmc/Ex0_company.csv).
Partner has a csv with identifiers (e.g., etc/example/dspmc/Ex0_partner_1.csv) and a csv with features (e.g., etc/example/dspmc/Ex0_partner_1_features.csv).

How Has This Been Tested (if it applies)

Tests are located in etc/example/dpmc and etc/example/dspmc.

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

facebook-github-bot commented 12 months ago

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 12 months ago

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 12 months ago

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

shubho commented 12 months ago

Can check you why we get

unresolved import `aws_sdk_s3::error::NoSuchUpload`

consider importing one of these items instead private_id_protocols/private_id/common/src/s3_path.rs

in lines 13 to 17?

jimouris commented 11 months ago

@shubho I updated the AWS crates, it should be fine now. Can you try again?

facebook-github-bot commented 11 months ago

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

shubho commented 11 months ago

Failed to resolve

failed to resolve: use of undeclared crate or module `fernet`

in ‎ private_id_protocols‎/private_id‎/protocol‎/src‎/dpmc‎/helper.rs‎ private_id_protocols‎/private_id‎/protocol‎/src‎/dpmc‎/partner.rs‎

shubho commented 11 months ago

can't find crate for `base64`

in private_id_protocols‎/private_id‎/protocol‎/src‎/dpmc‎/helper.rs‎ private_id_protocols‎/private_id‎/protocol‎/src‎/dpmc‎/partner.rs‎

jimouris commented 11 months ago

@shubho I updated these two crates to their latest versions. Their API had changed a bit. Let's see if that was the issue.

facebook-github-bot commented 11 months ago

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

shubho commented 11 months ago

I still get the same errors - the fernet errors are in line 113 and 174 private_id/protocol/src/dpmc/helper.rs line 182 and 285 private_id/protocol/src/dpmc/partner.rs

And the base64 errors are in line 4 in private_id/protocol/src/dpmc/helper.rs line 4 in private_id/protocol/src/dpmc/partner.rs

jimouris commented 11 months ago

I made some changes, can you check again? What is the command that generates these errors? I can't replicate them locally.

facebook-github-bot commented 11 months ago

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

shubho commented 11 months ago

Same problem when you do use base64 or use fernet they aren't resolving - do you need to do extern? The lines where you do use base64 (or fernet) - I get unresolved import base64 etc

jimouris commented 11 months ago

That's odd, both dependencies are in Cargo.toml and I have use statements. Based on this use should be sufficient. I had it with extern crate .. before and it was also causing the error.

Is there a way to find the specific Rust version and the command that generates the error?

shubho commented 11 months ago

I think the problem is the base64 and fernet packages don't exist in our internal build system - this will take longer than expected I think

prasadbuddhavarapu commented 11 months ago

Updated fernet, and base64 should be 0.13. We should do another pull to update.

facebook-github-bot commented 11 months ago

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 11 months ago

@shubho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 11 months ago

@prasadbuddhavarapu merged this pull request in facebookresearch/Private-ID@26b08dd59182cb835b94ca926dd4e8f624108a83.

facebookresearch / Private-ID