facebookresearch / ReAgent

A platform for Reasoning systems (Reinforcement Learning, Contextual Bandits, etc.)
https://reagent.ai
BSD 3-Clause "New" or "Revised" License
3.58k stars 521 forks source link

make reward net optional #641

Closed czxttkl closed 2 years ago

czxttkl commented 2 years ago

Summary: as titled

Differential Revision: D36039334

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D36039334

codecov-commenter commented 2 years ago

Codecov Report

Merging #641 (7bc485e) into main (f7ff588) will increase coverage by 0.00%. The diff coverage is 93.33%.

@@           Coverage Diff           @@
##             main     #641   +/-   ##
=======================================
  Coverage   87.06%   87.06%           
=======================================
  Files         354      354           
  Lines       22468    22478   +10     
  Branches       44       44           
=======================================
+ Hits        19561    19570    +9     
- Misses       2881     2882    +1     
  Partials       26       26           
Impacted Files Coverage Δ
reagent/training/parametric_dqn_trainer.py 84.69% <93.33%> (+0.60%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f7ff588...7bc485e. Read the comment docs.