facebookresearch / RidgeSketch

A Fast sketching based solver for large scale ridge regression
Other
17 stars 6 forks source link

ridgesketch should not be listed as an option for solvers #1

Open Sciroccogti opened 11 months ago

Sciroccogti commented 11 months ago

In the comment of class RidgeSketch, "ridgesketch" is listed as an option, but in fact it is not implemented.

solver (str): defaults to 'auto'.
    If dimensions small, uses direct solver.
    Otherwise, randomized solver.
    Options are "direct" or "ridgesketch" or "conjugate gradients".

Currently available solver seems to be:

    SKLEARN_SOLVERS = {
        "svd",
        "cholesky",
        "lsqr",
        "sag",
        "saga",
    }

    SKETCH_SOLVERS = {
        "direct",
        "cg",
        "subsample",
        "coordinate descent",
        "gaussian",
        "count",
        "subcount",
        "hadamard",
    }
ngazagna commented 11 months ago

Sorry for late reply @Sciroccogti , you are right the available options are

I will clarify the documentation.