search

facebookresearch / SentEval

A python tool for evaluating the quality of sentence embeddings.
Other
2.09k stars 309 forks source link

PyTorch 0.2 compatability #12

Closed MaximumEntropy closed 7 years ago

MaximumEntropy commented 7 years ago

I've noticed that a couple of things break when using PyTorch 0.2. Appears to be related to reductions no longer keeping the reduction axis in the new versrion. I can submit a PR if required.

aconneau commented 7 years ago

Sure, a PR would be great. I fixed some of it in https://github.com/facebookresearch/SentEval/commit/91f82751add3fea2cafc8afc16dc45ef72127850 already but apparently not all of them. Thanks.

MaximumEntropy commented 7 years ago

Apologies. I didn't notice that PR, I was on an older commit. Indeed, those fixes should work.