facebookresearch / SentEval

A python tool for evaluating the quality of sentence embeddings.
Other
2.09k stars 309 forks source link

Python 3.x compatibility #5

Closed tscheepers closed 7 years ago

tscheepers commented 7 years ago

Fixes #4

Tested on bow.py with Python 3.5 and 2.7. Exactly the same numbers roll out.

You can test it using pip install git+https://github.com/tscheepers/SentEval.git@setuppy

facebook-github-bot commented 7 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 7 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

aconneau commented 7 years ago

Merged in 94a41b41c1f13dbd58d30ff271e7867156d8f61d Thanks for your contribution!

aconneau commented 7 years ago

After "pip install git+https://github.com/facebookresearch/SentEval" (which works fine), I obtain the following error when trying to import senteval in a python shell:

import senteval Traceback (most recent call last): File "", line 1, in File "/home/aconneau/anaconda/lib/python2.7/site-packages/senteval/init.py", line 3, in from .senteval import SentEval File "/home/aconneau/anaconda/lib/python2.7/site-packages/senteval/senteval.py", line 15, in from binary import CREval, MREval, MPQAEval, SUBJEval ImportError: No module named binary

tscheepers commented 7 years ago

@aconneau I see, I'm fixing it right now