search

facebookresearch / SentEval

A python tool for evaluating the quality of sentence embeddings.
Other
2.09k stars 309 forks source link

Update utils.py to be compatible with 3.9 and on #87

Open stfwn opened 2 years ago

stfwn commented 2 years ago

inspect.getargspec has been deprecated since Python 3.0 (docs) and using it can result in errors with 3.9. Running the evaluation with Python 3.9 and up fails with:

  File "/home/stefan/.local/lib/python3.9/site-packages/senteval/utils.py", line 89, in get_optimizer
    expected_args = inspect.getargspec(optim_fn.__init__)[0]
  File "/usr/lib/python3.9/inspect.py", line 1122, in getargspec
    raise ValueError("Function has keyword-only parameters or annotations"
ValueError: Function has keyword-only parameters or annotations, use inspect.signature() API which can support them

This PR replaces inspect.getargspec with the drop-in replacement inspect.getfullargspec, as suggested in the docs.

facebook-github-bot commented 2 years ago

Hi @stfwn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

yuenherny commented 2 years ago

Didn't notice that this issue has been rectified with a PR. Could anyone merge this so that everyone who uses this has updated code?

Referring to Issue #88

yuenherny commented 2 years ago

Looking at the commit history, it seems no one is maintaining this repo anymore. Hence I forked this repo and implemented this fix onto my fork.

Tested this fix on Windows with Python 3.10.5 - works as intended. Thanks @stfwn for the fix.