search

facebookresearch / SpanBERT

Code for using and evaluating SpanBERT.
Other
884 stars 174 forks source link

fixed typo when loading from_tf #56

Closed oushu1zhangxiangxuan1 closed 4 years ago

oushu1zhangxiangxuan1 commented 4 years ago

A typo at https://github.com/facebookresearch/SpanBERT/blob/10641ea3795771dd96e9e3e9ef0ead4f4f6a29d2/code/pytorch_pretrained_bert/modeling.py#L551 will make people confused when loading model from_tf checkpoint.

And fixed it according to this line https://github.com/facebookresearch/SpanBERT/blob/10641ea3795771dd96e9e3e9ef0ead4f4f6a29d2/code/pytorch_pretrained_bert/modeling.py#L50

facebook-github-bot commented 4 years ago

Hi @oushu1zhangxiangxuan1!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

mandarjoshi90 commented 4 years ago

Thanks!

oushu1zhangxiangxuan1 commented 4 years ago

Thanks!

My pleasure, spanBert is awesome!