search

facebookresearch / StarSpace

Learning embeddings for classification, retrieval and ranking.
MIT License
3.94k stars 531 forks source link

fixing maxTrainTime restriction to stop all threads not only master #192

Closed kretes closed 6 years ago

kretes commented 6 years ago

maxTrainTime is an option to stop the training after particular number of seconds. However currently it just stops the master thread and what we get is that training is continued but without master.

This PR makes every training thread stop when maxTrainTime limit is hit.

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!