Adding bindings for predictOne and related methods and attributes

facebookresearch / StarSpace

Learning embeddings for classification, retrieval and ranking.

MIT License

3.95k stars 531 forks source link

Adding bindings for predictOne and related methods and attributes #221

Closed rnditdev closed 5 years ago

rnditdev commented 5 years ago

This PR adds the very useful predictOne method binding, at the cost of having to add some adapted methods in the core library. The use of functions receiving references as parameters seem not approachable, at least for me, so I added mirror functions without them. I'm not positive about having this PR merged, but it works, and probably will spark the light to a much better approach.

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

freakeinstein commented 5 years ago

wow. Super cool! Thanks.. why don’t this be added to existing code?

rnditdev commented 5 years ago

I'm not sure If I can sign the CLA. Would you take inspiration in my changes, and add new wrappers from your repo? Thanks!