facebookresearch / VMZ

VMZ: Model Zoo for Video Modeling
Apache License 2.0
1.04k stars 156 forks source link

Self-contained reproducible environment #94

Open daniel-j-h opened 4 years ago

daniel-j-h commented 4 years ago

Hey folks, we ported the r(2+1)d model and weights to PyTorch over in

https://github.com/moabitcoin/ig65m-pytorch

and had to run this project to e.g. get out activations to compare and verify the ported model.

The problems we ran into when trying to run this project were

Here are a few improvements which will give us self-contained and more importantly a reproducible environment for users, engineers, researchers, and scientists to run out their experiments.

Changes

This should resolve the problems I noted above.

Let me know what you think.

facebook-github-bot commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!