search

facebookresearch / audiocraft

Audiocraft is a library for audio processing and generation with deep learning. It features the state-of-the-art EnCodec audio compressor / tokenizer, along with MusicGen, a simple and controllable music generation LM with textual and melodic conditioning.
MIT License
20.62k stars 2.1k forks source link

add `on_change` event for `model: gr.Radio` to control visibility of `Melody: gr.Audio` #110

Closed HaiyiMei closed 1 year ago

HaiyiMei commented 1 year ago
facebook-github-bot commented 1 year ago

Hi @HaiyiMei!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

adefossez commented 1 year ago

This is now conflicting due to the major changes introduced with version 1.0.0. In any case, the logic in the demo is a bit complex, combining both a batch and non batch version, and this is a mostly cosmetic change, given we have no automated test on the demo, we won't accept such a change in the future.